Skip to content

Commit

Permalink
Apparently we can't have nice (caching) things
Browse files Browse the repository at this point in the history
Error: Invalid pattern '/home/runner/work/build-and-inspect-python-package/build-and-inspect-python-package/./action/requirements/tools.txt'. Relative pathing '.' and '..' is not allowed.
  • Loading branch information
hynek committed Aug 20, 2022
1 parent eaadf2a commit 2f0fdb3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
16 changes: 9 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- *twine* now runs in `--strict` mode.
- All tools are now pinned and cached to improve performance and reliability.
- The action now uses `setup-python` itself to enable pinning and caching.
Currently, Python 3.10 is used.
- The tools are installed into a virtual environment.
That means you can re-use the global Python environment and do further checks.

See for example how [*argon2-cffi-bindings*](https://github.com/hynek/argon2-cffi-bindings/blob/1bb072cdba857bc22c3fa1d976659279d1c08a23/.github/workflows/main.yml#L70-L79) uses it to check the wheels don't break a dependency.
- All tools are now pinned reliability (and hopefully caching in the future).
- The action now uses `setup-python` itself to enable pinning (and hopefully
caching in the future). Currently, Python 3.10 is used.
- The tools are installed into a virtual environment. That means you can re-use
the global Python environment and do further checks.

See for example how
[*argon2-cffi-bindings*](https://github.com/hynek/argon2-cffi-bindings/blob/1bb072cdba857bc22c3fa1d976659279d1c08a23/.github/workflows/main.yml#L70-L79)
uses it to check the wheels don't break a dependency.


## [0.1](https://github.com/hynek/build-and-inspect-python-package/tree/v0.1) - 2022-08-20
Expand Down
2 changes: 0 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ runs:
- uses: actions/setup-python@v4
with:
python-version: "3.10"
cache: pip
cache-dependency-path: "**/tools.txt"

- name: Create venv for tools
run: python3.10 -m venv /tmp/baipp
Expand Down

0 comments on commit 2f0fdb3

Please sign in to comment.