Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defmacro! no longer crashes when modifying arguments #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scauligi
Copy link
Member

Fixes #112.

@Kodiologist
Copy link
Member

Thus we see the value of hylang/hy#2410. Ain't I smart?

The implementation looks good. In tests, I think it would be better to assert against a value produced by each macro, and use hy.eval instead of macroexpand-all.

@Kodiologist
Copy link
Member

Actually, you don't even need hy.eval, since the tests are passing.

@scauligi
Copy link
Member Author

I can make them use hy.eval; I wanted to use something that would compile at runtime, otherwise on test failure (which would be a compilation / test-collection failure) pytest can't run any tests at all.

@Kodiologist
Copy link
Member

otherwise on test failure (which would be a compilation / test-collection failure) pytest can't run any tests at all

I know. The way tests are written in both Hy and Hyrule, this is pretty normal. Even if I'd scrupulously avoided that, Hy's regression tests tend to have a lot of other interdependencies.

@scauligi
Copy link
Member Author

Fair enough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defmacro! can't modify its arguments
2 participants