Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network module on macOS #56

Merged
merged 7 commits into from
Dec 24, 2022

Conversation

leana8959
Copy link

Description

Network module wasn't working on macOS, this patch is to fix it.

Have a nice day :)

@hykilpikonna
Copy link
Owner

Works!

image

@hykilpikonna hykilpikonna merged commit 14c7963 into hykilpikonna:master Dec 24, 2022
@hykilpikonna
Copy link
Owner

Nice fix, thank you for your efforts!

@devnoname120
Copy link
Contributor

devnoname120 commented Oct 21, 2024

@leana8959 Network module looks broken on my end:

❯ hyfetch
                    c.'          paul@Pauls-MacBook-Air
                 ,xNMM.          ----------------------
               .OMMMMo           OS: macOS Sonoma 14.7 (23H124) arm64
               lMM"              Host: MacBook Air (M1, 2020)
     .;loddo:.  .olloddol;.      Kernel: Darwin 23.6.0
   cKMMMMMMMMMMNWMMMMMMMMMM0:    Uptime: 2 days, 6 hours, 39 mins
 .KMMMMMMMMMMMMMMMMMMMMMMMWd.    Packages: 4 (pipx), 8 (npm), 445 (brew)
 XMMMMMMMMMMMMMMMMMMMMMMMX.      Shell: zsh 5.9
;MMMMMMMMMMMMMMMMMMMMMMMM:       Editor: VIM - Vi IMproved 9.1
:MMMMMMMMMMMMMMMMMMMMMMMM:       Resolution: 1680x1050 @2x @ 60Hz
.MMMMMMMMMMMMMMMMMMMMMMMMX.      DE: Aqua
 kMMMMMMMMMMMMMMMMMMMMMMMMWd.    WM: yabai
 'XMMMMMMMMMMMMMMMMMMMMMMMMMMk   Terminal: iTerm2
  'XMMMMMMMMMMMMMMMMMMMMMMMMK.   Terminal Font: MesloLGS-NF-Regular 13
    kMMMMMMMMMMMMMMMMMMMMMMd     CPU: Apple M1 (8)
     ;KMMMMMMMWXXWMMMMMMMk.      GPU: Apple M1 (8)
       "cooc*"    "*coo'"        Memory: 12.14 GiB / 16.00 GiB (75%)
                                 Network: en0: Wi-Fi@Mbps
                                 Disk (/): 9.6G / 460G (16%)
                                 Locale: en_US.UTF-8
                                 Java: 20.0.2
                                 Node: 20.18.0

Here is an alternative:

$ system_profiler SPAirPortDataType | grep -i 'transmit rate'
              Transmit Rate: 1200

@leana8959
Copy link
Author

@devnoname120 That's unfortunate :/

I don't use macOS on a daily basis anymore, and I'm quite busy recently. Maybe you could try making a PR (if possible ?). I basically just awk and sed on some Apple's internal utilities that shows the bandwidth, maybe they changed the API of these.

@devnoname120
Copy link
Contributor

@leana8959 No worries I'll submit a PR :)

@devnoname120
Copy link
Contributor

@leana8959 Done in #360.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants