Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add str concat for pydantic_core.Url #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add str concat for pydantic_core.Url #46

wants to merge 1 commit into from
+25 −4

Conversation

sblack-usu
Copy link
Contributor

@sblack-usu sblack-usu commented Mar 4, 2024 •
edited
Loading

A temporary fix for url string concatenation until pydantic_core.Url extends str again. pydantic/pydantic#8281

devincowan
devincowan approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@devincowan devincowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 questions for you if you have the time

hsmodels/__init__.py Show resolved Hide resolved
tests/test_metadata.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devincowan devincowan devincowan approved these changes

@pkdash pkdash pkdash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sblack-usu @pkdash @devincowan