Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to make a relay driver inverted #674

Merged
merged 2 commits into from
Jun 25, 2019

Conversation

andrewebdev
Copy link
Contributor

I did not want to break any existing projects that already use the RelayDriver, but at the same time didn't want to create a completely new RelayDriver that has all the same functionality as the standard one, execpt that it's inverted.

For this reason I didn't updated the signature for NewRelayDriver and rather opted to add SetInverted which can then set this value after the initial instance was created.

[#648]

@codecov
Copy link

codecov bot commented Jun 2, 2019

Codecov Report

Merging #674 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #674      +/-   ##
==========================================
+ Coverage   77.27%   77.29%   +0.01%     
==========================================
  Files         158      158              
  Lines       10935    10944       +9     
==========================================
+ Hits         8450     8459       +9     
  Misses       2030     2030              
  Partials      455      455
Impacted Files Coverage Δ
drivers/gpio/relay_driver.go 92.15% <100%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d73466a...b926d1e. Read the comment docs.

@andrewebdev
Copy link
Contributor Author

@deadprogram updated the PR; Inverted is now public

@deadprogram
Copy link
Member

Thanks for working on this and making the requested changes, @andrewebdev now merging.

@deadprogram deadprogram merged commit c7d6ea7 into hybridgroup:dev Jun 25, 2019
@andrewebdev andrewebdev deleted the 648-inverted-relaydriver branch June 26, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants