remove redundant stringify (#7)

* string check * encode cookie
hwookim · Oct 18, 2023 · 00bbd18 · 00bbd18
1 parent b7fffe4
commit 00bbd18
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/packages/addon/src/types.ts b/packages/addon/src/types.ts
@@ -1,4 +1,4 @@
-export type Cookie = Record<string, unknown>;
+export type Cookie = Record<string, string>;
 
 export type CookieParameter = {
   cookie?: Cookie;

diff --git a/packages/addon/src/utils.ts b/packages/addon/src/utils.ts
@@ -1,11 +1,16 @@
 import { Cookie } from './types';
 
-export function setCookie(name: string, value: unknown) {
-  document.cookie = `${name}=${JSON.stringify(value)}`;
+export function setCookie(name: string, value: string) {
+  if (typeof value !== 'string') {
+    document.cookie = `${name}=${JSON.stringify(value)};`;
+  } else {
+    const encodedValue = encodeURIComponent(value);
+    document.cookie = `${name}=${encodedValue};`;
+  }
 }
 
 export function setCookies(cookie: Cookie) {
-  const entries: [string, unknown][] = Object.keys(cookie).map((name) => [
+  const entries: [string, string][] = Object.keys(cookie).map((name) => [
     name,
     cookie[name],
   ]);