-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a better optimized node image. #34
Conversation
Have you tested this locally beyond just building the image? Alpine has discrepancies in regard to the C compiler and other small changes that could potentially throw issues with some of our dependencies, along with the image not being tested as extensively as the main Node images. |
Sorry. Should have been a draft. I'll continue once I have more time. It is crashing on an existing installation. Somehow without any error. Could it be prisma? |
With this new alpine image, or the existing one that is published? |
The new one. I'll have to take a deeper dive why it is crashing. Normally NodeJS should be platform independent and I didn't saw any installation in your Dockerfile. But yeah. It definitely needs some testing. |
Seems like it was something with the environment file validation that (unsure why) only failed when using the Alpine image. Give it another shot after pulling from |
I get this:
|
I had to add HTTP_PORT and set the HOST variable. But now it is working without a problem. BTW you can set variables also with
that way you don't have to write VARIABLE=$VARIABLE and can just keep the other more complicated variables like database url. |
Not sure why I didn't have that - could have sworn I was just passing the file. If you add that I'll merge this, the Alpine image is certainly smaller. |
Done |
node latest includes a lot of bloat that is not really needed for a normal nodejs application.