Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Vault 1.6-1.10 #1074

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Conversation

briantist
Copy link
Contributor

@briantist briantist commented Oct 14, 2023

Breaking changes

  • Drop unsupported Vault versions 1.6 through 1.10 in CI (https://endoflife.date/hashicorp-vault)
    • 1.6 and 1.7 remain tested as enterprise versions, mostly because we haven't been able to properly test enterprise versions without a license past those
    • unsupported versions still remain, we will probably become more aggressive about dropping them in the future
    • while dropping these from CI doesn't mean that hvac won't work against these versions, it does mean we don't test against them and don't enforce new or edited code to be compatible with them

@briantist briantist added CI/CD related to CI/CD (not necessarily tests) breaking-change labels Oct 14, 2023
@briantist briantist added this to the 2.0.0 milestone Oct 14, 2023
@briantist briantist self-assigned this Oct 14, 2023
@briantist
Copy link
Contributor Author

briantist commented Oct 14, 2023

It seems there's some change in the behavior of kubernetes support in Vault 1.15.x and a test is not getting the result that is expected. I'm going to make this PR about dropping older versions for 2.0.0, and adding 1.15 will have to be done later when there's time to investigate the kubernetes issues. Adding a new Vault version won't be a breaking change and can be done in a minor version.

@briantist briantist changed the title Support Vault 1.15.x, drop Vault 1.6-1.10 Drop Vault 1.6-1.10 Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #1074 (5062c27) into main (b8322ca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   86.99%   86.99%           
=======================================
  Files          64       64           
  Lines        3115     3115           
=======================================
  Hits         2710     2710           
  Misses        405      405           

@briantist briantist marked this pull request as ready for review October 14, 2023 16:25
@briantist briantist requested a review from a team as a code owner October 14, 2023 16:25
@briantist briantist changed the title Drop Vault 1.6-1.10 Drop support for Vault 1.6-1.10 Oct 15, 2023
@briantist briantist added the announcement Announces some change or future change to be aware of label Oct 15, 2023
@briantist briantist merged commit ade6739 into hvac:main Oct 15, 2023
33 checks passed
@briantist briantist deleted the ci/drop-old-vault branch October 15, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
announcement Announces some change or future change to be aware of breaking-change CI/CD related to CI/CD (not necessarily tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants