Skip to content

[release/8.0] Detect ephemeral client cert key via SEC_E_UNKNOWN_CREDENTIALS in QUIC - #1

Closed
huyn7539 wants to merge 1815 commits into
mainfrom
antelier-replay/pr-133090
Closed

[release/8.0] Detect ephemeral client cert key via SEC_E_UNKNOWN_CREDENTIALS in QUIC#1
huyn7539 wants to merge 1815 commits into
mainfrom
antelier-replay/pr-133090

Fix tests

3183101
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / Antelier · claim check succeeded Sep 3, 2026 in 0s

Antelier · claim check

Claim check for #2 — all 3 checked claims present

Details

Claim check for #2 — all 3 checked claims present

Claims vs diff (10)
# Claim (quoted from the PR) Label Evidence
1 fixes test failures to de-noise CI. present src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs @@ -1364,5 +1364,90 @@ L1364 — test file is present in the PR file list
2 Regression was introduced by updating MsQuic to the latest version. present src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs @@ -1364,5 +1364,90 @@ L1364 — test file is present in the PR file list
3 Fix tests present src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs @@ -1364,5 +1364,90 @@ L1364 — test file is present in the PR file list
—
7 not checkable (show)
  1. A recent update in MsQuic changed an error code returned when applicaiton attempted to use certificates with ephemeral keys (Windows-only concept where keys are not persisted in a key store, Schannel, the TLS provider on Windows does not work with such certificates). — not checked (judged tier off)
  2. This causes to a hard-to-diagnose exception being surfaced to .NET application. — not checked (judged tier off)
  3. This change: — not decidable from the diff
  4. fixes the error detection so that more helpful diagnostic exception is surfaced — not checked (judged tier off)
  5. Low, the fix is contained and well understood. — not decidable from the diff
  6. [release/8.0] Detect ephemeral client cert key via SEC_E_UNKNOWN_CREDENTIALS in QUIC — not decidable from the diff
  7. Backport PR dotnet#132832: Recognize SEC_E_UNKNOWN_CREDENTIALS in MsQuic cr… — not decidable from the diff
 not checkable collapsed by default
Attention (2)
  1. undisclosed-file — File changed but not mentioned in the PR body — src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs — src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs @@ -1364,5 +1364,90 @@ L1364-L1453
  2. ci-reported — CI — reported claim-check: IN_PROGRESS; reported, not observed by Work Loop — src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs @@ -1364,5 +1364,90 @@ L1364-L1453
Author attestation — draft, confirm or edit

What changed: fixes test failures to de-noise CI. — src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs @@ -1364,5 +1364,90 @@ L1364
Why: Why this change was made is not established by the excluded motivation text; confirm intent. — src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs @@ -1364,5 +1364,90 @@ L1364
What could break: No touched exported symbol establishes what could break; confirm callers or behavior at this diff. — src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs @@ -1364,5 +1364,90 @@ L1364
What was tested: fixes test failures to de-noise CI. — src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs @@ -1364,5 +1364,90 @@ L1364

Confirm attestation in Antelier

After confirmation, each answer is checked against the same diff as the PR claims.

Rules applied (2) · Provenance · Not read (7 lines)
  • Rule: Claim labels use fetched patch bytes only
  • Rule: Citations are verified before rendering
    Provenance: human login huyn7539; Co-authored-by rzikm → agent-assisted (reported)
  • Not read: > Replay of dotnet#133090 (agent PR, head 3183101) on a fork, to test Antelier against a real large repo. Nothing here is proposed for upstream.
  • Not read: - [ ] Customer reported
  • Not read: - [x] Found internally
  • Not read: - [X] Yes
  • Not read: - [ ] No
  • Not read: verified in CI.
  • Not read: Initial plan

Rule version claim-check-rubric-v1 · JSON route /api/truth/v1/pr/2

Generated by Antelier. Every citation resolves to diff bytes; no human has reviewed these results.

View more details on GitHub Actions