Repository navigation
fix(storybook): @storybook/* を 10.6.1 に上げて TanStack Router のテスト失敗を修正 - #52
Merged
Merged
Conversation
@tanstack/router-core 1.171 で interpolatePath のシグネチャが変わり、 @storybook/tanstack-react 10.6.0 では全 story が "path.endsWith is not a function" で描画に失敗していた。 10.6.1 に両シグネチャ対応(storybookjs/storybook#36333)が入っている。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Storybook の patch をグループ内でまとめて 10.6.1 に上げる。
Evidence
Before: main(6add3ae)の CI は failure(run 37475910330)。手元でも全 30 story が同じエラーで落ちる。
After:
pnpm checkも pass。@tanstack/router-core1.171 でinterpolatePathのシグネチャが変わり、@storybook/tanstack-react10.6.0 が旧シグネチャのまま全 story の描画時に落ちていた。10.6.1 の "TanStack: Support both interpolatePath signatures"(storybookjs/storybook#36333)で修正されている。Merge Danger
Door: two-way(
@storybook/*を 10.6.0 に戻すだけ)Blast Radius: 開発・テスト時のみ(Storybook 10.6.x 内の patch 更新)