Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thesaurus label matching hotfix #6943

Merged
merged 10 commits into from
Jun 27, 2024

Conversation

LaszloKecskes
Copy link
Contributor

fixes #6942

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@LaszloKecskes LaszloKecskes requested a review from fnocetti June 27, 2024 12:59
Copy link
Contributor

@fnocetti fnocetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and it works.
What I'm wondering is: creating thesaurus values through the thesaurus ui allows for labels that only differ in casing. e.g. "a" and "A" can co-exists.
Is this "case insensitivity" feature desired in the csv import?

@LaszloKecskes
Copy link
Contributor Author

The code looks good and it works. What I'm wondering is: creating thesaurus values through the thesaurus ui allows for labels that only differ in casing. e.g. "a" and "A" can co-exists. Is this "case insensitivity" feature desired in the csv import?

As far as I can remember the discussion, yes. We are explicitly testing for it, we've just missed this case on the csv side when added the option to import grouped values. So I've added some more thorough testing on the thesaurus side.

@fnocetti
Copy link
Contributor

The code looks good and it works. What I'm wondering is: creating thesaurus values through the thesaurus ui allows for labels that only differ in casing. e.g. "a" and "A" can co-exists. Is this "case insensitivity" feature desired in the csv import?

As far as I can remember the discussion, yes. We are explicitly testing for it, we've just missed this case on the csv side when added the option to import grouped values. So I've added some more thorough testing on the thesaurus side.

Makes sense!

@LaszloKecskes LaszloKecskes merged commit a9524b5 into production Jun 27, 2024
14 checks passed
@LaszloKecskes LaszloKecskes deleted the thesaurus_label_matching_hotfix branch June 27, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants