V2 translate #6569
Merged
V2 translate #6569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also check this -> #5068 |
Zasa-san
force-pushed
the
v2-translate
branch
from
af49aef to
4714ab6
Compare
daneryl
reviewed
Jan 28, 2025
app/api/i18n/routes.ts
Outdated
| @@ -158,6 +169,45 @@ export default (app: Application) => { | |||
| } | |||
| ); | |||
|
|
|||
| app.post( | |||
There was a problem hiding this comment.
Are this changes still needed ? looks like i18n.v2 has the same endpoints defined ?
There was a problem hiding this comment.
🤦♂️ An oversight. Fixed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6691 #7350