[v0.38] Fix / OrderBookTracker debug logging substitutions #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheHolyRoger
force-pushed
the
fix/orderbooktracker-debuglog
branch
3 times, most recently
from
d3ae6c4 to
7315a2a
Compare
CrimsonJacket
suggested changes
Apr 1, 2021
There was a problem hiding this comment.
@TheHolyRoger Note that we have renamed BitMax -> AscendEX. Hence the conflict. Overall the PR looks good but do make the necessary fixes for the conflict.
TheHolyRoger
force-pushed
the
fix/orderbooktracker-debuglog
branch
from
7315a2a to
d550968
Compare
|
@CrimsonJacket done now thanks! |
dennisocana
changed the title
dennisocana
approved these changes
Apr 2, 2021
There was a problem hiding this comment.
According to @CrimsonJacket PR looks good overall. Since the file conflicts have already been addressed and thorough testing is not required for this fix, adding approval to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
At some point logger was changed and all these substitutions don't work, they just print %s, %d etc in the debug log. Fixing them in this PR.