Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump swift-nio-http2 from 1.28.0 to 1.34.1 #635

Conversation

bcbod2002
Copy link
Contributor

@bcbod2002 bcbod2002 commented Dec 11, 2024

Bump swift-nio-http2 dependency from 1.28.0 to 1.34.1, due to HTTP2Channel can't be compiled after split HTTP2 channel out from upgrade channel

@adam-fowler
Copy link
Member

Can you run swift package update that argument is in a later version of swift-nio -http2.

For this PR instead could you ensure we are running with version 1.34.0 of swift-nio-http2

@Joannis
Copy link
Member

Joannis commented Dec 11, 2024

@adam-fowler I believe we should bump our HTTP2 dependency then right?

@Joannis
Copy link
Member

Joannis commented Dec 11, 2024

Is there a SwiftPM option to pull the lowest versions available for each dependency? That might be helpful for this

@adam-fowler
Copy link
Member

@adam-fowler I believe we should bump our HTTP2 dependency then right?

That's what I was asking @bcbod2002 to do. Maybe I wasn't clear enough.

@bcbod2002
Copy link
Contributor Author

Hi @adam-fowler, yes after I bump the dependency swift-nio-http2 to 1.34.1. It shows the parameter streamDelegate in configureAsyncHTTP2Pipeline function. Looks like we don't need to remove this argument.

Maybe we should just need to update the version number of swift-nio-http2 in Package from 1.28.0 to 1.34.1 in this PR?

@adam-fowler
Copy link
Member

Yes please

@bcbod2002 bcbod2002 force-pushed the fix/remove-extra-parameter-http-2-channel branch from e5c972f to abb873d Compare December 11, 2024 10:06
@bcbod2002 bcbod2002 changed the title Bug fix: Remove the extra argument when using configureAsyncHTTP2Pipeline Bump swift-nio-http2 from 1.28.0 to 1.34.1 Dec 11, 2024
@bcbod2002
Copy link
Contributor Author

bcbod2002 commented Dec 11, 2024

Hi @adam-fowler , @Joannis
Just have updated the PR, please check. Thanks

@adam-fowler adam-fowler merged commit 81ef0c2 into hummingbird-project:main Dec 11, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants