Add versions to hot-patched symbols

[smoench]

fixes #420

[smoench]

It is related to nikic/PHP-Parser#715. Using a none emulative lexer would fix this bug. Specs needs somehow to be skipped on none supported php versions. Any ideas?

[theofidry]

Specs needs somehow to be skipped on none supported php versions. Any ideas?

I think it would make sense to be able to declare the min PHP version required for a given spec or spec file

[smoench]

I added a minPhpVersin-key to the meta spec

[smoench]

Ready for review. In #420 Sebastian Bergmann has proved it is working.

[theofidry]

Thanks a lot! This is a big improvement 👏

Keep in mind that until we change the phpstorm stubs generated map to record the version used there, we are still missing the version for all of those symbols (the one you did is only the "hot patched" symbols). I'm saying this just as a note to be aware, having this is already quite quite helpful

[smoench]

Keep in mind that until we change the phpstorm stubs generated map to record the version used there, we are still missing the version for all of those symbols (the one you did is only the "hot patched" symbols). I'm saying this just as a note to be aware, having this is already quite quite helpful

Yes, I had this in mind. But unfortunately T_MATCH has no @since-annotation https://github.com/JetBrains/phpstorm-stubs/blame/master/tokenizer/tokenizer.php#L133

[smoench]

Applied proposals, CS and resolved conflicts. Ready for merge :-)

A follow up task would be generating a map of classes, function and constants with the related php version they have been introduced. (or similar)

[theofidry]

Cool, thanks a lot for the work @smoench!