Skip to content
This repository has been archived by the owner on Mar 15, 2020. It is now read-only.

2.0: Backwards compatibility breaking changes #43

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

padraic
Copy link
Collaborator

@padraic padraic commented May 19, 2017

  • API updated: Constructor param order changed; Accept strategy objects as required param.
  • Tests and README updated.
  • Remove humbug_get_contents() as dependency.

TODO

  • Rename setStrategyObject to setStrategy and remove older method.
  • Set GithubStrategy to not upgrade to next major version by default.
  • Use file existence checks instead for error suppression on unlink() calls?
  • Move SHA hash checks to ShaStrategyAbstract from Updater.

Tests and README updated.
@padraic padraic changed the title 2.0: Backwards compatibility breaking changes [WIP] 2.0: Backwards compatibility breaking changes May 19, 2017
@theofidry
Copy link
Member

We should create a new 1.x branch. Would it be possible to push the 256 strat to the 1.x?

@padraic
Copy link
Collaborator Author

padraic commented May 19, 2017

I'm thinking there won't be another 1.x release, just a rolled up 2.0 release capturing all fixes and changes, so essentially it would be branching from the last tag to 1.x for posterity or a significant security issue.

@theofidry
Copy link
Member

Hm, I would like to review in more details phar-updater before a 2.x, which would significantly delay it :/

@padraic
Copy link
Collaborator Author

padraic commented May 19, 2017

@theofidry You can definitely take time to review it. I'm all out of PRs on this one, so whatever changes are currently in the PRs are it from my side.

@padraic padraic changed the title [WIP] 2.0: Backwards compatibility breaking changes 2.0: Backwards compatibility breaking changes May 21, 2017
@padraic padraic added this to the 1.1.0 milestone May 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants