-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure and apply pre-commit #280
Conversation
350c399
to
5f1486c
Compare
While we're at it, I think we should also apply black to reformat python code, by adding this section to - repo: https://github.com/psf/black
rev: 22.3.0
hooks:
- id: black |
9005aa5
to
f904404
Compare
run `pre-commit run -a`
I would like that people looking at
|
We can also exclude these reformating commits from git blame, with |
Didn't know about this. Indeed, that makes code reformatting a lot more attractive ! |
Then I suggest we merge this, and release. Should I handle that ? |
Don't you want to add the git blame file first ? |
sure |
To use it, either: - git blame --ignore-revs-file .git-blame-ignore-revs - git config blame.ignoreRevsFile .git-blame-ignore-revs
PS: Github support for this feature is still in beta: community/community#5033 But it looks like this is alrealy working: |
Should we expand the README on how to use pre-commit and to manually set the git-blame setting (per commit message it needs to be set manually on every developer machine)?
|
I'm not sure how useful it would be to add more docs about those standard tools here. They are becoming pretty common, and for anybody who is not aware of those, github UI will automatically provide the right blame, and pre-commit.ci will automatically add commits to re-format if needed. But I won't oppose if someone provide that doc :) |
I can handle the release soon also. |
Before doing the new release, I will fix this issue #267. |
The new release version will thus be 2.0.0 |
Related to #279.