Use output.path when inferring publicPath #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a multiple-config Webpack setup, builds to two different output directories appear to both need a specified, unique publicPath in order for those bundles to be accessible as expected within the dev server. To ensure that default usage creates bundles which can be loaded correctly in a multi-config DevServer environment, we adapt the value of output.path (stripping out the filePath cwd base) for use as a subdirectory within the in-memory virtual filesystem of the DevServer.
goldenapples
approved these changes
Jan 25, 2021
Contributor
There was a problem hiding this comment.
I haven't pulled this code down and tested it with live configs to see if it accounts for every case I can throw at it, but it makes sense and the test coverage looks good.
There's a note in the dev config presets the public path needs to be set by the consumer. Should that comment be updated to note that the config will try to guess a useful public path if not specified?
kadamwhite
added a commit
that referenced
this pull request
Feb 1, 2021
**New Features** - Adapt the value of `output.path` when inferring `output.publicPath` in DevServer so that all assets are correctly served in multi-config situations. [#156](#156) - Generate a `production-asset-manifest.json` for all production preset builds. [#153](#153) Builds in a multi-configuration setup which target the same output folder will share a manifest. [#154](#154) **Upgrades & Changes** - **Potentially Breaking**: Update `mini-css-extract-plugin` to v1.3.4. [Changelog](https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/CHANGELOG.md). [#148](#148) - **Potentially Breaking**: Update `css-loader` to v5.0.1. [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md). [#136](#136) - **Potentially Breaking**: Update `style-loader` to v2.0.0. [Changelog](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md). [#127](#127) All three of the above dependency upgrades include breaking API changes. None of these changes should impact vanilla usage of the [presets](https://humanmade.github.io/webpack-helpers/modules/presets.html) provided by these helpers, but we recommend reviewing all three libraries' changelogs to identify potential issues if you are [customizing presets or loader behavior](https://humanmade.github.io/webpack-helpers/modules/presets.html#customizing-presets) relating to stylesheets. - **Potentially Breaking**: Update `webpack-manifest-plugin` to v3.0.0. [Changelog](https://github.com/shellscape/webpack-manifest-plugin/releases). [#143](#143) The manifest plugin now exports its constructor as a named export, not a default, so any custom builds which pull in the `ManifestPlugin` constructor directly from the plugin dependency (as opposed to using the recommended `plugins.manifest()` factory function) will need to switch to using `plugins.constructors.ManifestPlugin`. This should not impact un-customized presets. - **Potentially Breaking**: Update `postcss-flexbugs-fixes` to v5.0.2 and update `postcss-loader` to v4.1.0. [#152](#152) The upgrade to `postcss-loader` requires nesting PostCSS configuration options within a `.postcssOptions` key on the object passed to the webpack loader. As with the style loading changes above, if you use the presets without customization this should not impact your project. Otherwise, ensure you have added this level of nesting to any code which customizes the `postcss-loader`'s configuration object. Consult the [`postcss-loader` changelog](https://github.com/webpack-contrib/postcss-loader/blob/master/CHANGELOG.md#-breaking-changes) for more information. - Upgrade `webpack-fix-style-only-entries` plugin to v0.6.0. This may resolve the issue previously documented in [#93](#93) where files would be incorrectly deleted when processing an array of webpack configuration objects. [#129](#129) - Include `postcss` as a direct dependency of this package, rather than a subdependency. [#151](#151) - Update `webpack-bundle-analyzer` bundled plugin to v4.3.0. [#146](#146) - Internal: Add the generation of a basic development and production bundle, including scss styles, to the CI job. [#149](#149) - Internal: Upgrade local development dependencies to latest versions. [#150](#150)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a multiple-config Webpack setup, builds to two different output directories appear to both need a specified, unique publicPath in order for those bundles to be accessible as expected within the dev server.
To ensure that default usage creates bundles which can be loaded correctly in a multi-config DevServer environment, we adapt the value of output.path (stripping out the filePath cwd base) for use as a subdirectory within the in-memory virtual filesystem of the DevServer.
I encountered this behavior while testing v0.10-beta.1, and in a happy coincidence fixing it also fills in some of our
.todotests...