New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests assume deterministic ordering of XML attributes #112

Open

danielhers opened this issue Dec 15, 2020 · 1 comment

Member

danielhers commented Dec 15, 2020

https://github.com/huji-nlp/ucca/runs/1550684343?check_suite_focus=true

In Python 3.8, this ordering is no longer guaranteed, so the test fails.

Member Author

danielhers commented Dec 15, 2020

@lovodkin93 would you like to take a look and either fix the test or fix the XML IO functionality?

danielhers added a commit that referenced this issue


          Disable Python 3.8 testing until #112 is resolved

24fb280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment