Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the install script - again #1053

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Fixed the install script - again #1053

merged 5 commits into from
Jan 31, 2024

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Jan 20, 2024

Description

Make it use the latest stable release
Currently the ref was empty (was spotted in the screenshot in #1049)

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

Copy link

🤖 Coverage update for b6f3f68 🟢

Old New
Commit 219d46f b6f3f68
Score 71.7764% 71.7764% (0)

1 similar comment
Copy link

🤖 Coverage update for b6f3f68 🟢

Old New
Commit 219d46f b6f3f68
Score 71.7764% 71.7764% (0)

Copy link

🤖 Coverage update for 55a7524 🟢

Old New
Commit 219d46f 55a7524
Score 71.7764% 71.7959% (0.0195)

Copy link

🤖 Coverage update for 55a7524 🟢

Old New
Commit 219d46f 55a7524
Score 71.7764% 71.7764% (0)

Copy link

🤖 Coverage update for cf2f07c 🟢

Old New
Commit 219d46f cf2f07c
Score 71.7764% 71.7764% (0)

1 similar comment
Copy link

🤖 Coverage update for cf2f07c 🟢

Old New
Commit 219d46f cf2f07c
Score 71.7764% 71.7764% (0)

Copy link

🤖 Coverage update for a344d56 🟢

Old New
Commit 219d46f a344d56
Score 71.7764% 71.7764% (0)

1 similar comment
Copy link

🤖 Coverage update for a344d56 🟢

Old New
Commit 219d46f a344d56
Score 71.7764% 71.7764% (0)

Copy link
Collaborator

@Grazfather Grazfather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add get-pip.py?

@hugsy
Copy link
Owner Author

hugsy commented Jan 25, 2024

Why did you add get-pip.py?

To test gef-extras.sh, but it's a bit tricky to test

Copy link

🤖 Coverage update for ab6beb5 🔴

Old New
Commit 219d46f ab6beb5
Score 71.5816% 71.5623% (-0.0193)

1 similar comment
Copy link

🤖 Coverage update for ab6beb5 🔴

Old New
Commit 219d46f ab6beb5
Score 71.5816% 71.5623% (-0.0193)

Copy link
Collaborator

@Grazfather Grazfather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a clean machine. Works as except.

@hugsy hugsy merged commit 32d1e91 into main Jan 31, 2024
6 checks passed
@hugsy hugsy deleted the fix_install_script branch January 31, 2024 03:09
hugsy added a commit that referenced this pull request Feb 1, 2024
We now stop using 3rd party tool, only rely on bash and python3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants