Skip to content
This repository has been archived by the owner on Dec 21, 2022. It is now read-only.

Update prettier & fix parser warnings #6

Closed
wants to merge 2 commits into from

Conversation

ismail-syed
Copy link

@ismail-syed ismail-syed commented Nov 7, 2017

This PR fixes #3, and fixes #5.

As per this comment: deprecated postcss in favor of css.

Before

  • using postcss, we see the warnings:
    screen shot 2017-11-07 at 4 49 25 pm

After

  • with css, no warnings:
    screen shot 2017-11-07 at 4 53 34 pm

@codecov
Copy link

codecov bot commented Nov 7, 2017

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files           2        2           
  Lines          51       51           
=======================================
  Hits           50       50           
  Misses          1        1
Impacted Files Coverage Δ
src/index.js 98% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e37e73...24afc99. Read the comment docs.

@lucasmotta
Copy link

@hugomrdias any chance you can look into this PR? Very simple change, but it removes a very annoying deprecation warning.

@paleite
Copy link

paleite commented May 4, 2018

Would be awesome if we could get an update on this, @hugomrdias !

@mazhermon
Copy link

Keen for this also. Getting a lot of noise in the console even when using the --quiet flag. Thanks for the great package though :) Super keen for this patch to go in. Cheers

@isellsoap
Copy link

I created a temporary package containing these fixes: https://www.npmjs.com/package/prettier-stylelint-temp

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants