Fix invalid replacement when assignment #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hughsk Not sure what your policy is on collaborators merging their own PRs. A little guidance please? |
hughsk
added a commit
that referenced
this pull request
Mar 12, 2015
Fix invalid replacement when assignment
|
@zertosh ah sorry, missed this one – thanks! Looks good to me. In the future I'd say submit a PR, and if you don't hear from me after a day then merge away :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests passed before because they were testing computed
MemberExpressions, which aren't supported. Brought up in #21.@yoshuawuyts Can you give this a quick look before I merge + publish?