dashboard: Fix historical version compatibility problem for auth chec…

…k via localStorage (alibaba#1473)
hughpearse · May 15, 2020 · 905ee04 · 905ee04
1 parent 09c6ce5
commit 905ee04
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/sentinel-dashboard/src/main/webapp/resources/app/scripts/directives/header/header.js b/sentinel-dashboard/src/main/webapp/resources/app/scripts/directives/header/header.js
@@ -27,7 +27,15 @@ angular.module('sentinelDashboardApp')
             }
           });
         } else {
-          handleLogout($scope, JSON.parse($window.localStorage.getItem("session_sentinel_admin")).id)
+          try {
+            var id = JSON.parse($window.localStorage.getItem("session_sentinel_admin")).id;
+            handleLogout($scope, id);
+          } catch (e) {
+            // Historical version compatibility processing, fixes issue-1449
+            // If error happens while parsing, remove item in localStorage and redirect to login page.
+            $window.localStorage.removeItem("session_sentinel_admin");
+            $state.go('login');
+          }
         }
 
         function handleLogout($scope, id) {