Update rules reader for structure #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a whole load of reverse engineering, I've discovered that Outlook's rule reader has the concept of "Parameters", which are essentially arguments passed to rules elements.
The top level structure of rules is unchanged
...
The structure of a rule is unchanged
However, the structure of a rule element is changed
Notice that Outlook rules supports multiple parameters, whereas this wasn't explicitly supported in the structure
I've also added support for reading/writing separate versions, and done a whole bunch of associated cleanups and fixes
This PR still needs to be updated to include changes to the specification.