Align KTO with DPO: Use _metrics attribute#5705
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c2ec97c. Configure here.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Align KTO with DPO: Use
_metricsattribute.Part of:
This PR refactors how training and evaluation metrics are stored and managed in the
KTOTrainerclass, replacing the previous_stored_metricsstructure with a new_metricsdictionary. This change centralizes metric tracking and simplifies metric handling throughout the class.Changes
Metrics storage and management:
_stored_metricsattribute (a nesteddefaultdict) with a new_metricsdictionary, initialized to separately track "train" and "eval" metrics.store_metrics,log) to use the new_metricsstructure instead of_stored_metrics, ensuring consistent metric accumulation and cleanup.These changes improve code clarity and reduce the risk of errors when handling training and evaluation metrics.
Note
Low Risk
Low risk refactor limited to how
KTOTraineraccumulates and clears train/eval metrics, but it could affect what gets logged if the new containers are mishandled.Overview
Updates
KTOTrainerto use a unified_metricscontainer (split intotrainandeval) instead of_stored_metrics, aligning metric bookkeeping with DPO.Metric accumulation (
store_metrics) and log-time aggregation/cleanup (log) are refactored to write into and clear from the new structure, including the chosen/rejected count-based averaging logic.Reviewed by Cursor Bugbot for commit 881aec3. Bugbot is set up for automated code reviews on this repo. Configure here.