[docs] Add LLaMA 3 / Qwen 2.5 entries to chat_templates/README#5545
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
requested review from
AmineDiro,
albertvillanova,
kashif and
sergiopaniego
sergiopaniego
approved these changes
Apr 16, 2026
sergiopaniego
left a comment
sergiopaniego
left a comment
Member
There was a problem hiding this comment.
lgtm! should this also be documented in the docs (web)? if so, we can add that update either here or in a follow-up pr
Member
Author
|
Good point, we should do it in a next pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We forgot to document it
Note
Low Risk
Documentation-only changes; no runtime or training logic is modified.
Overview
Documents the previously undocumented
llama3.jinjaandqwen2_5.jinjaoriginal chat templates intrl/chat_templates/README.md.Also adds README entries for the corresponding training templates (
llama3_training.jinja,qwen2_5_training.jinja) and clarifies that they wrap assistant output in{% generation %}/{% endgeneration %}for correct SFT assistant-only loss masking (mirroring the existinggptoss_training.jinjanote).Reviewed by Cursor Bugbot for commit d1b4c7d. Bugbot is set up for automated code reviews on this repo. Configure here.