Remove post-collation truncation from SFT#5359
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
qgallouedec
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Remove post-collation truncation from SFT.
Follow-up to:
Related to:
This PR removes internal dataset truncation logic from the SFT trainer and enforce that sequence truncation should be handled before padding. This change shifts responsibility for truncation to the dataset preparation or custom collators, making the data processing pipeline more explicit and less error-prone.
Changes
Removal of internal truncation logic:
truncate_datasetfunction in the dataset processing pipeline; the trainer no longer performs truncation internally if packing is not enabled.tokenize_fnto reflect that only packing (not truncation) is performed during dataset preparation.Documentation and enforcement of truncation responsibility:
data_collatorparameter to specify that custom collators must truncate sequences before padding; the trainer will not perform truncation after collation.skip_prepare_dataset" and clarify that inputs must be packed/truncated before reaching the collator ifpadding_free=True.Note
Medium Risk
Changes SFT data-prep semantics by removing automatic dataset truncation when
packing=False, which can increase sequence lengths and affect memory/accuracy unless callers pre-truncate. Adds stricter validation forpadding_free=Truewithmax_length, potentially breaking existing configs that relied on implicit enforcement.Overview
Removes trainer-side dataset truncation from
SFTTrainerwhenpacking=False, leaving sequence length control to pre-truncated inputs or custom collators (packing remains the only built-in length enforcement during dataset prep).Tightens and clarifies configuration rules by raising an error when
padding_free=Trueis used without packing alongside a non-Nonemax_length, and updates thedata_collatordocstring to state that custom collators must truncate before padding.Updates the related unit test to reflect the new error condition/message for padding-free + no packing +
max_length.Written by Cursor Bugbot for commit 12f9514. This will update automatically on new commits. Configure here.