Skip to content

Fix GRPOTrainer attribute access for vLLM model config #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qgallouedec merged 1 commit into from
Mar 19, 2026
Merged

Fix GRPOTrainer attribute access for vLLM model config #5302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion trl/trainer/grpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1424,7 +1424,7 @@ async def _run_async_tools(async_coros):
**self.chat_template_kwargs,
)
if self.use_vllm and self.vllm_mode == "colocate":
max_model_len = self.llm.llm_engine.model_config.max_model_len
max_model_len = self.vllm_generation.llm.llm_engine.model_config.max_model_len
elif not self.use_vllm:
max_model_len = self.model.config.max_position_embeddings
else:
Expand Down
Loading