Decouple rollout dispatch from vLLM backend in GRPO _generate_single_turn#5122
Open
albertvillanova wants to merge 4 commits intohuggingface:mainfrom
Open
Decouple rollout dispatch from vLLM backend in GRPO _generate_single_turn#5122albertvillanova wants to merge 4 commits intohuggingface:mainfrom
albertvillanova wants to merge 4 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
Can you confirm that after this one, |
Member
|
Another important change is that trl/trl/experimental/openenv/utils.py Lines 129 to 134 in 57df014 the line 132 should be updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements step 1 of #5119 by:
rollout_funcdispatch to a top-level branch inGRPOTrainer._generate_single_turn, independent of vllm_generation.The goal is to decouple rollout/agent logic from inference backend internals.
Fix #5121.
Supersede and close #4712.
Part of:
What changed
Motivation
Previously, rollout_func lived inside VLLMGeneration, coupling rollout/agent logic to one inference backend. This change makes rollout dispatch backend-agnostic at the trainer layer and narrows VLLMGeneration to inference concerns.
Related