Fix SFT loss type rewards being overwritten in dpo_loss()#5079
Merged
qgallouedec merged 1 commit intohuggingface:mainfrom Feb 16, 2026
Merged
Fix SFT loss type rewards being overwritten in dpo_loss()#5079qgallouedec merged 1 commit intohuggingface:mainfrom
qgallouedec merged 1 commit intohuggingface:mainfrom
Conversation
In dpo_loss(), the SFT loss branch correctly sets chosen_rewards and rejected_rewards to zeros since SFT has no preference rewards. However, the unconditional reward computation at the end of the method overwrites these zeros with standard DPO implicit rewards. This causes incorrect reward metrics when using SFT as part of a multi-loss configuration (e.g., MPO with ["sigmoid", "bco_pair", "sft"]). The accumulated rewards are inflated because the SFT component contributes DPO-style rewards instead of zeros, leading to misleading reward_accuracies and reward margin metrics. The fix guards the reward computation so it only applies to non-SFT loss types, preserving the intended zero rewards for SFT.
qgallouedec
approved these changes
Feb 16, 2026
Member
qgallouedec
left a comment
There was a problem hiding this comment.
thanks, this makes sense. Note that DPO is being refactored in #3906, I'm checking if we're not doing the same mistake.
qgallouedec
approved these changes
Feb 16, 2026
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dpo_loss(), thesftloss branch correctly setschosen_rewardsandrejected_rewardsto zeros (since SFT has no preference rewards), but the unconditional reward computation at the end of the method overwrites these with standard DPO implicit rewards["sigmoid", "bco_pair", "sft"]), because the SFT component contributes DPO-style rewards instead of the intended zerosTest plan
test_train_with_multiple_loss_typestest continues to passloss_type=["sigmoid", "sft"]and verify reward metrics are no longer inflated by the SFT componentloss_type="sigmoid") is unaffected