Move VLLMClient to generation module#4928
Merged
albertvillanova merged 2 commits intohuggingface:mainfrom Jan 29, 2026
Merged
Conversation
qgallouedec
approved these changes
Jan 29, 2026
Member
qgallouedec
left a comment
qgallouedec
left a comment
There was a problem hiding this comment.
Nice, please update this one as well
https://github.com/huggingface/trl/blob/main/trl/extras/vllm_client.py#L91
nenuadrian
pushed a commit
to nenuadrian/trl
that referenced
this pull request
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move VLLMClient to generation module.
This PR primarily reorganizes the location of the
VLLMClientmodule within the codebase, moving it from thetrl/extrasdirectory to thetrl/generationdirectory.See comment in:
Refactor vLLM generation [1/N]: Extract vLLM generation #4700 (comment)