Skip to content

Comments

Transformers v5 release: extend xfail condition for TestGRPOTrainer.test_training_vlm_and_liger and update version checks#4898

Merged
qgallouedec merged 4 commits intomainfrom
fix-ci-liger-vlm
Jan 26, 2026
Merged

Transformers v5 release: extend xfail condition for TestGRPOTrainer.test_training_vlm_and_liger and update version checks#4898
qgallouedec merged 4 commits intomainfrom
fix-ci-liger-vlm

Conversation

@qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Jan 26, 2026

  1. extend xfail condition for TestGRPOTrainer.test_training_vlm_and_liger

Transformers PR

introduced a Liger-Kernel bug reported in

and fixed in

but not yet released.

TRL currently xfails this test only for dev Transformers (see #4601),
but Transformers 5.0.0 has now been released, so the bug affects stable too. This PR extends the xfail to
Transformers >= 5.0.0 when liger_kernel <= 0.6.4.

  1. This PR also replaces transformers 5.0.0.dev0 version check by 5.0.0
  2. xfail zero3 test for grpo and aloo, see RLOO and GRPO failing with ZeRO3 #4899

@qgallouedec
Copy link
Member Author

No maintainer is available at the moment, so I will merge this PR without review, so that we can advertise support on day one of transformers v5 with a clean green CI

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec changed the title Update xfail condition for TestGRPOTrainer to account for liger-kerne… Extend xfail condition for TestGRPOTrainer.test_training_vlm_and_liger after transformers v5 release Jan 26, 2026
@qgallouedec qgallouedec changed the title Extend xfail condition for TestGRPOTrainer.test_training_vlm_and_liger after transformers v5 release Transformers v5 release: extend xfail condition for TestGRPOTrainer.test_training_vlm_and_liger and update version checks Jan 26, 2026
@qgallouedec qgallouedec merged commit 4322778 into main Jan 26, 2026
13 of 14 checks passed
@qgallouedec qgallouedec deleted the fix-ci-liger-vlm branch January 26, 2026 18:57
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @qgallouedec!! 🤗

nenuadrian pushed a commit to nenuadrian/trl that referenced this pull request Feb 1, 2026
…test_training_vlm_and_liger` and update version checks (huggingface#4898)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants