Transformers v5 release: extend xfail condition for TestGRPOTrainer.test_training_vlm_and_liger and update version checks#4898
Merged
qgallouedec merged 4 commits intomainfrom Jan 26, 2026
Merged
Conversation
Member
Author
|
No maintainer is available at the moment, so I will merge this PR without review, so that we can advertise support on day one of transformers v5 with a clean green CI |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
TestGRPOTrainer.test_training_vlm_and_liger after transformers v5 release
TestGRPOTrainer.test_training_vlm_and_liger after transformers v5 releaseTestGRPOTrainer.test_training_vlm_and_liger and update version checks
kashif
approved these changes
Jan 26, 2026
Member
albertvillanova
left a comment
There was a problem hiding this comment.
Thanks, @qgallouedec!! 🤗
nenuadrian
pushed a commit
to nenuadrian/trl
that referenced
this pull request
Feb 1, 2026
…test_training_vlm_and_liger` and update version checks (huggingface#4898)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestGRPOTrainer.test_training_vlm_and_ligerTransformers PR
get_decoder()for multimodal and delete redundant code 🔪 transformers#42156introduced a Liger-Kernel bug reported in
and fixed in
but not yet released.
TRL currently xfails this test only for dev Transformers (see #4601),
but Transformers 5.0.0 has now been released, so the bug affects stable too. This PR extends the xfail to
Transformers >= 5.0.0 when liger_kernel <= 0.6.4.
5.0.0.dev0version check by5.0.0