Skip to content

Fix _patch_transformers_hybrid_cache also for peft #4820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertvillanova merged 3 commits into from
Jan 14, 2026
Merged

Fix _patch_transformers_hybrid_cache also for peft #4820

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab83cdc
Apply _patch_transformers_hybrid_cache also for peft<0.18.0
albertvillanova Jan 13, 2026
6e3a85b
Update warning message
albertvillanova Jan 13, 2026
30137ad
Update docstring
albertvillanova Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions trl/_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,14 +150,15 @@ def __reduce__(self):

def _patch_transformers_hybrid_cache() -> None:
"""
Fix HybridCache import compatibility for liger_kernel<=0.6.4.
Fix HybridCache import for transformers v5 compatibility.

- Issue: liger_kernel imports HybridCache from transformers.cache_utils
- Issue: liger_kernel and peft import HybridCache from transformers.cache_utils
- HybridCache removed in https://github.com/huggingface/transformers/pull/43168 (transformers>=5.0.0.dev0)
- Fixed in https://github.com/linkedin/Liger-Kernel/pull/1002 (will be released in liger_kernel>=0.6.5)
- This patch can be removed when TRL requires liger_kernel>=0.6.5
- Fixed in liger_kernel: https://github.com/linkedin/Liger-Kernel/pull/1002 (released in v0.6.5)
- Fixed in peft: https://github.com/huggingface/peft/pull/2735 (released in v0.18.0)
- This can be removed when TRL requires liger_kernel>=0.6.5 and peft>=0.18.0
"""
if _is_package_version_below("liger_kernel", "0.6.5"):
if _is_package_version_below("liger_kernel", "0.6.5") or _is_package_version_below("peft", "0.18.0"):
try:
import transformers

Expand All @@ -167,7 +168,7 @@ def _patch_transformers_hybrid_cache() -> None:

cache_utils.HybridCache = cache_utils.Cache
except Exception as e:
warnings.warn(f"Failed to patch liger_kernel HybridCache compatibility: {e}", stacklevel=2)
warnings.warn(f"Failed to patch transformers HybridCache compatibility: {e}", stacklevel=2)


# Apply vLLM patches
Expand Down
Loading