Align use of vllm_max_model_length in RLOOTrainer#4702
Merged
albertvillanova merged 2 commits intohuggingface:mainfrom Dec 16, 2025
Merged
Align use of vllm_max_model_length in RLOOTrainer#4702albertvillanova merged 2 commits intohuggingface:mainfrom
albertvillanova merged 2 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
reviewed
Dec 16, 2025
trl/trainer/rloo_config.py
Outdated
| Control the GPU memory utilization for vLLM. This setting only applies when `vllm_mode` is set to | ||
| `"colocate"`. If you are using `vllm_mode="server"`, this parameter must be passed separately when | ||
| launching the vLLM server via the `--vllm_gpu_memory_utilization` flag. | ||
| vllm_max_model_length (`int`, *optional*, defaults to `None`): |
Member
There was a problem hiding this comment.
Suggested change
| vllm_max_model_length (`int`, *optional*, defaults to `None`): | |
| vllm_max_model_length (`int`, *optional*): |
can you possibly apply the same in grpo config?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align use of
vllm_max_model_lengthin RLOOTrainer.Align it with
GRPOTrainer, introduced in PR:This alignment is required to make simpler this PR: