Skip to content

Remove module-level imports of extra deps in experimental.judges #4598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertvillanova merged 3 commits into from
Nov 28, 2025
Merged

Remove module-level imports of extra deps in experimental.judges #4598

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
362fe79
Remove module-level imports of extra deps in experimental.judges
albertvillanova Nov 28, 2025
8d6667d
Force CI tests
albertvillanova Nov 28, 2025
042c648
Revert "Force CI tests"
albertvillanova Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions trl/experimental/judges/judges.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,6 @@
from ...import_utils import is_llm_blender_available


if is_llm_blender_available():
import llm_blender

if is_openai_available():
from openai import OpenAI


DEFAULT_PAIRWISE_SYSTEM_PROMPT = '''I require a leaderboard for various large language models. I'll provide you with prompts given to these models and their corresponding outputs. Your task is to assess these responses, and select the model that produces the best output from a human perspective.

## Instruction
Expand Down Expand Up @@ -213,6 +206,8 @@ class PairRMJudge(BasePairwiseJudge):
def __init__(self):
if not is_llm_blender_available():
raise ValueError("llm-blender is not installed. Please install it with `pip install llm-blender`.")
import llm_blender

self.blender = llm_blender.Blender()
self.blender.loadranker("llm-blender/PairRM", device=Accelerator().device)

Expand Down Expand Up @@ -362,6 +357,8 @@ def __init__(
):
if not is_openai_available():
raise ValueError("OpenAI client is not installed. Please install it with 'pip install openai'.")
from openai import OpenAI

self.client = OpenAI()
self.model = model
self.system_prompt = system_prompt or DEFAULT_PAIRWISE_SYSTEM_PROMPT
Expand Down
Loading