[GRPOTrainer bug fix] a little bug in completions with bootstrap#4442
Closed
SolarWindRider wants to merge 6 commits into
Closed
[GRPOTrainer bug fix] a little bug in completions with bootstrap#4442SolarWindRider wants to merge 6 commits into
SolarWindRider wants to merge 6 commits into
Conversation
SolarWindRider
changed the title
SolarWindRider
changed the title
Member
|
thanks, can you slit this PR into two PRs instead please? |
Contributor
Author
Sure, I split the grpotrainer bug fix in there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Fix a little bug in GRPOTrainer.
When inputs are conversational, bootstrap is a list not str, causing a str concat error.
I add a bootstrap type check to fix the bug while maintain the original program
2. Add a new GRPO family Trainer