Skip to content

Replace unittest skipTest with pytest.skip #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertvillanova merged 1 commit into from
Oct 15, 2025
Merged

Replace unittest skipTest with pytest.skip #4263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tests/slow/test_grpo_slow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,11 +329,11 @@ def reward_func(prompts, completions, **kwargs):
assert lora_params_changed, "No LoRA parameters were updated during training."

except torch.OutOfMemoryError as e:
self.skipTest(f"Skipping VLM training test due to insufficient GPU memory: {e}")
pytest.skip(f"Skipping VLM training test due to insufficient GPU memory: {e}")
except Exception as e:
# Check for other memory-related errors
if any(keyword in str(e).lower() for keyword in ["memory", "cuda", "out of memory", "insufficient"]):
self.skipTest(f"Skipping VLM training test due to hardware constraints: {e}")
pytest.skip(f"Skipping VLM training test due to hardware constraints: {e}")
else:
raise

Expand Down Expand Up @@ -474,11 +474,11 @@ def dummy_reward_func(completions, **kwargs):
"decrease gpu memory",
]
):
self.skipTest(f"Skipping vLLM colocate test due to hardware constraints: {e}")
pytest.skip(f"Skipping vLLM colocate test due to hardware constraints: {e}")
elif "KeyError" in str(e) and "RANK" in str(e):
self.skipTest(f"Skipping vLLM colocate test due to environment setup issues: {e}")
pytest.skip(f"Skipping vLLM colocate test due to environment setup issues: {e}")
elif "ValueError" in str(e) and "memory" in str(e).lower():
self.skipTest(f"Skipping vLLM colocate test due to memory constraints: {e}")
pytest.skip(f"Skipping vLLM colocate test due to memory constraints: {e}")
else:
raise
finally:
Expand Down Expand Up @@ -541,11 +541,11 @@ def test_training_vllm(self):
"decrease gpu memory",
]
):
self.skipTest(f"Skipping vLLM training test due to hardware constraints: {e}")
pytest.skip(f"Skipping vLLM training test due to hardware constraints: {e}")
elif "KeyError" in str(e) and "RANK" in str(e):
self.skipTest(f"Skipping vLLM training test due to environment setup issues: {e}")
pytest.skip(f"Skipping vLLM training test due to environment setup issues: {e}")
elif "ValueError" in str(e) and "memory" in str(e).lower():
self.skipTest(f"Skipping vLLM training test due to memory constraints: {e}")
pytest.skip(f"Skipping vLLM training test due to memory constraints: {e}")
else:
raise

Expand Down
2 changes: 1 addition & 1 deletion tests/test_gkd_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ def test_gkd_trainer_with_liger(self):

# Ensure liger fused JSD path is enabled; if not, skip (runtime may lack system libs)
if not getattr(trainer, "use_liger_gkd_loss", False):
self.skipTest("Liger fused JSD not enabled at runtime; skipping fused-loss assertion")
pytest.skip("Liger fused JSD not enabled at runtime; skipping fused-loss assertion")

trainer.train()

Expand Down
Loading