Add optimizer_cls_and_kwargs attribute to PPO and RLOO#2302
Merged
qgallouedec merged 3 commits intomainfrom Oct 31, 2024
Merged
Add optimizer_cls_and_kwargs attribute to PPO and RLOO#2302qgallouedec merged 3 commits intomainfrom
optimizer_cls_and_kwargs attribute to PPO and RLOO#2302qgallouedec merged 3 commits intomainfrom
Conversation
5 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After huggingface/transformers#34358, a trainer has a
self.optimizer_cls_and_kwargs. However, PPO and RLOO doesn't callsuper().__init__()in their__init__method. Consequently,self.optimizer_cls_and_kwargsis not defined, resulting toThis PR fixes our CI "Tests with dev dependencies".
Mentioned here #2288 (comment)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.