Relax numpy upper bound and bump deepspeed version#1990
Merged
lewtun merged 2 commits intohuggingface:mainfrom Aug 29, 2024
Merged
Relax numpy upper bound and bump deepspeed version#1990lewtun merged 2 commits intohuggingface:mainfrom
lewtun merged 2 commits intohuggingface:mainfrom
Conversation
Contributor
Author
|
Running tests locally passed I'm not sure if this actually tests anything related to DeepSpeed with |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
Thanks for the review! 🤗 |
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeepSpeed
v0.14.4and later supports current numpy (confirmed in deepspeedai/DeepSpeed#5671).This should allow us to get rid of the upper bound on numpy after a version bump of DeepSpeed.
See #1747 for original pin.