Skip to content

Remove MPS #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qgallouedec merged 1 commit into from
Aug 27, 2024
Merged

Remove MPS #1983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions trl/trainer/online_dpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
is_apex_available,
is_sagemaker_mp_enabled,
is_torch_mlu_available,
is_torch_mps_available,
is_torch_npu_available,
is_torch_xpu_available,
logging,
Expand All @@ -28,7 +27,13 @@
from ..models.utils import unwrap_model_for_generation
from .judges import BasePairwiseJudge
from .online_dpo_config import OnlineDPOConfig
from .utils import DPODataCollatorWithPadding, get_reward, prepare_deepspeed, truncate_right
from .utils import (
DPODataCollatorWithPadding,
get_reward,
prepare_deepspeed,
trl_sanitze_kwargs_for_tagging,
Copy link
Member Author

@lewtun lewtun Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this since it was missing in the imports

truncate_right,
)


if is_apex_available():
Expand Down Expand Up @@ -429,12 +434,8 @@ def empty_cache(self):
torch.xpu.empty_cache()
elif is_torch_mlu_available():
torch.mlu.empty_cache()
# elif is_torch_musa_available():
# torch.musa.empty_cache()
elif is_torch_npu_available():
torch.npu.empty_cache()
elif is_torch_mps_available(min_version="2.0"):
torch.mps.empty_cache()
else:
torch.cuda.empty_cache()

Expand Down