Skip to content

Bugfix: Preserve token fields when converting TrainingArguments to SFTConfig #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kashif merged 6 commits into from
Jul 3, 2024
Merged

Bugfix: Preserve token fields when converting TrainingArguments to SFTConfig #1794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8db8a30
Preserve token fields when converting TrainingArguments to SFTConfig
noahlt Jul 1, 2024
f7d073e
run precommit
noahlt Jul 1, 2024
6b8b5fa
one-line args_as_dict definition per suggestion from kashif
noahlt Jul 2, 2024
90e8f60
generalize token copying to match TrainingArguments behavior
noahlt Jul 2, 2024
9efc9b9
unwrap |= on dict, to support python 3.8
noahlt Jul 2, 2024
953b9fa
use .update instead of |= or for-loop
noahlt Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/test_sft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ def test_sft_trainer_backward_compatibility(self):
eval_steps=2,
save_steps=2,
per_device_train_batch_size=2,
hub_token="not_a_real_token",
)

trainer = SFTTrainer(
Expand All @@ -232,6 +233,8 @@ def test_sft_trainer_backward_compatibility(self):
eval_dataset=self.eval_dataset,
)

assert trainer.args.hub_token == training_args.hub_token

trainer.train()

assert trainer.state.log_history[(-1)]["train_loss"] is not None
Expand Down
5 changes: 4 additions & 1 deletion trl/trainer/sft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,10 @@ def __init__(
warnings.warn(f"No `SFTConfig` passed, using `output_dir={output_dir}`.")
args = SFTConfig(output_dir=output_dir)
elif args is not None and args.__class__.__name__ == "TrainingArguments":
args = SFTConfig(**args.to_dict())
args_as_dict = args.to_dict()
# Manually copy token values as TrainingArguments.to_dict() redacts them
args_as_dict.update({k: getattr(args, k) for k in args_as_dict.keys() if k.endswith("_token")})
args = SFTConfig(**args_as_dict)

if model_init_kwargs is not None:
warnings.warn(
Expand Down