Skip to content

Fix overriding optimize_device_cache with optimize_cuda_cache in PPOConfig #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
younesbelkada merged 2 commits into from
Jun 3, 2024
Merged

Fix overriding optimize_device_cache with optimize_cuda_cache in PPOConfig #1690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c4ca58
Don't override optimize_device_cache when optimize_cuda_cache is not …
alexisrozhkov Jun 2, 2024
c99c536
Minor fix
alexisrozhkov Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions trl/trainer/ppo_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,11 @@ class PPOConfig:
warnings.warn(
"The `optimize_cuda_cache` argument will be deprecated soon, please use `optimize_device_cache` instead."
)

if optimize_device_cache is True:
raise ValueError("Both `optimize_device_cache` and `optimize_cuda_cache` were provided")

optimize_device_cache = optimize_cuda_cache
else:
optimize_device_cache = False

def __post_init__(self):
if self.forward_batch_size is not None:
Expand Down