Skip to content

Fix inheritance order in PPOv2Config #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vwxyzjn merged 2 commits into from
May 23, 2024
Merged

Fix inheritance order in PPOv2Config #1659

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2650e6
fix inheritance order in PPOv2Config
Nicolinho May 23, 2024
f50753c
fix inheritance order in rloo_config
Nicolinho May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion trl/trainer/ppov2_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@


@dataclass
class PPOv2Config(TrainingArguments, OnpolicyRuntimeConfig):
class PPOv2Config(OnpolicyRuntimeConfig, TrainingArguments):
# common config
exp_name: str = os.path.basename(__file__)[: -len(".py")]
"""the name of this experiment"""
Expand Down