Skip to content

[DPO] add 'bco_pair' loss_type#1524

Merged
younesbelkada merged 2 commits intohuggingface:mainfrom
seanexp:pairwise_bco
Apr 22, 2024
Merged

[DPO] add 'bco_pair' loss_type#1524
younesbelkada merged 2 commits intohuggingface:mainfrom
seanexp:pairwise_bco

Conversation

@seanexp
Copy link
Contributor

@seanexp seanexp commented Apr 11, 2024

add Binary Classifier Optimization (BCO) loss function from https://arxiv.org/abs/2404.04656

Implemented bce loss and reward shift in the paper.

I will make separate PR for unpaired version of BCO after rebase and polishing.

@kashif kashif self-requested a review April 12, 2024 09:59
@kashif
Copy link
Collaborator

kashif commented Apr 12, 2024

thanks @seanexp perhaps lets also add some description in the DPO docs too?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@seanexp
Copy link
Contributor Author

seanexp commented Apr 12, 2024

@kashif

Ah yes! I'll work on it.

@seanexp
Copy link
Contributor Author

seanexp commented Apr 12, 2024

@kashif

Just added BCO description. 5439c90

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition !

@younesbelkada younesbelkada merged commit c050ebc into huggingface:main Apr 22, 2024
kashif pushed a commit to kashif/trl that referenced this pull request Apr 23, 2024
* add 'bco_pair' loss_type

* add BCO description to DPO doc

---------

Co-authored-by: sean.jung <sean.jung@seanjungui-MacBookPro.local>
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
* add 'bco_pair' loss_type

* add BCO description to DPO doc

---------

Co-authored-by: sean.jung <sean.jung@seanjungui-MacBookPro.local>
@qgallouedec qgallouedec mentioned this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments