Skip to content

Pass kwargs to Pipeline's tokenizer call #9143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guyrosin wants to merge 1 commit into from
Closed

Pass kwargs to Pipeline's tokenizer call #9143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/transformers/pipelines/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,7 @@ def _parse_and_tokenize(
return_tensors=self.framework,
padding=padding,
truncation=truncation,
**kwargs,
)

return inputs
Expand Down
5 changes: 4 additions & 1 deletion tests/test_pipelines_fill_mask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,12 @@ def test_torch_fill_mask(self):
self.assertIsInstance(outputs, list)

# This used to fail with `cannot mix args and kwargs`
outputs = nlp(valid_inputs, something=False)
outputs = nlp(valid_inputs, verbose=False)
self.assertIsInstance(outputs, list)

# This fails because `invalid_arg` is not an argument of the pipeline's tokenizer
self.assertRaises(TypeError, nlp, valid_inputs, invalid_arg=False)

@require_torch
def test_torch_fill_mask_with_targets(self):
valid_inputs = ["My name is <mask>"]
Expand Down