[wip] [ci] doc-job-skip take #4.5 dry-run via github direct edit#8997
Closed
[wip] [ci] doc-job-skip take #4.5 dry-run via github direct edit#8997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is take 4.5 on attempting to find a reliable way to get a list of modified files of this PR. It's identical to #8980 but this PR was created from github UI direct file edit, so as we can see, it doesn't provide
CIRCLE_PR_NUMBER- Nothing bad happens, but the check can't be done since we have no information to work with :(It also happens with PR's made from a non-personal branch, #9015
And the result is that the check is completely skipped as it has no data to work with:
https://app.circleci.com/pipelines/github/huggingface/transformers/17118/workflows/48285d78-cb04-4feb-87f8-77cb02ac2593/jobs/134493
Hoping that circlePR will fix that bug.
This PR:
head.user.loginfor the username to checkout the branch with - using PR username as it's in the master will not work if the branch is coming from a non-forked repo (original that is). (could also use.head.repo.full_namefor the whole thing at once.)For now I will let this PR sit for a while and add other fixes if we find more edge cases.