Skip to content

[CI] implement job skipping for doc-only PRs #8826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LysandreJik merged 22 commits into from
Nov 29, 2020
Merged

[CI] implement job skipping for doc-only PRs #8826

Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
6b09594
implement job skipping for doc-only PRs
stas00 Nov 27, 2020
f730f2a
silent grep is crucial
stas00 Nov 27, 2020
dd66c3a
wip
stas00 Nov 27, 2020
76f0a6f
wip
stas00 Nov 27, 2020
621741c
wip
stas00 Nov 27, 2020
2f53929
wip
stas00 Nov 27, 2020
10d38ee
wip
stas00 Nov 27, 2020
88f1e5f
wip
stas00 Nov 27, 2020
346667c
wip
stas00 Nov 27, 2020
1f8d114
wip
stas00 Nov 27, 2020
4cf3cec
let's add doc
stas00 Nov 27, 2020
aa7cb7b
let's add code
stas00 Nov 27, 2020
5d6f2fb
revert test commits
stas00 Nov 27, 2020
b3777eb
Merge remote-tracking branch 'origin/master' into ci-skip-docs
stas00 Nov 27, 2020
1f18604
restore
stas00 Nov 27, 2020
8f4f69c
Better name
stas00 Nov 27, 2020
b9b44b7
Better name
stas00 Nov 27, 2020
7d27473
Better name
stas00 Nov 27, 2020
013f7d2
some more testing
stas00 Nov 27, 2020
397d76c
some more testing
stas00 Nov 27, 2020
d32c303
some more testing
stas00 Nov 27, 2020
1c43ec1
finish testing
stas00 Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,22 @@ orbs:
gcp-gke: circleci/[email protected]
go: circleci/[email protected]

commands:
skip-job-on-doc-only-changes:
description: "Do not continue this job and exit with success for PRs with only doc changes"
steps:

- run:
name: docs-only changes skip check
command: |
if git diff --name-only << pipeline.git.base_revision >>...<< pipeline.git.revision >> | egrep -qv '\.(md|rst)$'
then
echo "Non-docs were modified in this PR, proceeding normally"
else
echo "Only docs were modified in this PR, quitting this job"
circleci step halt
fi

# TPU REFERENCES
references:
checkout_ml_testing: &checkout_ml_testing
Expand Down Expand Up @@ -72,6 +88,7 @@ jobs:
parallelism: 1
steps:
- checkout
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-torch_and_tf-{{ checksum "setup.py" }}
Expand All @@ -98,6 +115,7 @@ jobs:
parallelism: 1
steps:
- checkout
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-torch-{{ checksum "setup.py" }}
Expand All @@ -124,6 +142,7 @@ jobs:
parallelism: 1
steps:
- checkout
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-tf-{{ checksum "setup.py" }}
Expand All @@ -150,6 +169,7 @@ jobs:
parallelism: 1
steps:
- checkout
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-flax-{{ checksum "setup.py" }}
Expand All @@ -176,6 +196,7 @@ jobs:
parallelism: 1
steps:
- checkout
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-torch-{{ checksum "setup.py" }}
Expand All @@ -202,6 +223,7 @@ jobs:
parallelism: 1
steps:
- checkout
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-tf-{{ checksum "setup.py" }}
Expand All @@ -226,6 +248,7 @@ jobs:
RUN_CUSTOM_TOKENIZERS: yes
steps:
- checkout
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-custom_tokenizers-{{ checksum "setup.py" }}
Expand Down Expand Up @@ -253,6 +276,7 @@ jobs:
parallelism: 1
steps:
- checkout
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-torch_examples-{{ checksum "setup.py" }}
Expand Down