-
Notifications
You must be signed in to change notification settings - Fork 32.4k
[WIP] Add Tapas model #8113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[WIP] Add Tapas model #8113
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
1142960
First commit
9bb0060
Added TapasForSequenceClassification
ac313f3
Improved documentation
e6eeed9
Improved loss calculation and documentation of TapasForQuestionAnswering
3383e79
Improved documentation
13cadf7
Some more improved documentation
13c7cda
Added fix for conversion of TapasForSequenceClassification
8f80607
First attempt at using nn.linear rather than nn.parameter for TapasFo…
3114c8c
Bug fix with TapasForSequenceClassification
da1d0e0
Simplified aggregation head using nn.Linear
78fc0f4
Improved testing
58ff811
Minor fix
86aa165
Fix numbering of models
eb99107
Added herbert since this was not included
e259580
Added data utilities which were also not included
42d5d27
Fixed README
538a67e
Fixed docs comments LysandreJik and replaced add_start_docstrings_to_…
4564135
Make TapasConfig inherit from PretrainedConfig instead of BertConfig …
2f44197
Added tapas utilities to modeling_tapas
9418015
Make TapasTokenizer inherit from PreTrainedTokenizer rather than Bert…
c236808
Added missing imports to tokenization_tapas
7ee992e
Added tokenization_tapas_utilities to tokenization_tapas
11c0a0d
Address PatrickVonPlaten's comments
37d8870
Address @LysandreJik's comments
da59db9
Fix important typo
e3e2304
Style
LysandreJik 81d56b2
TAPAS tokenizer & tokenizer tests (#8482)
LysandreJik 6407254
Merge pull request #2 from huggingface/tapas-style
NielsRogge 162c17d
Improve numeric value parsing
bd3ccd5
Add prev_label_ids logic
8889bb4
Major documentation improvements
d7c3f64
Implement correct padding of label_ids, numeric_values and numeric_va…
d4d1ec5
Further improve documentation
e802b39
Added [EMPTY] special token
bce3db4
Revert support of empty special token
1ce6526
Added initial implementation of [EMPTY] token
b95cef7
Use return_dict=True by default
a54aa90
Added conversion of TapasModel
0363264
Address some comments by @patrickvonplaten (mainly docs)
6b05d83
Do not pass entire config to calculate aggregation loss
9400277
Bug fix
4b4a1b4
Address most docs related comments by @sgugger
8a936f0
Some more docs improvements
40847a3
Truncation
LysandreJik cb0395b
Tokenization integration test
LysandreJik 4b93499
TAPAS modeling integration test template
LysandreJik ec7761b
Fix tests
LysandreJik 50c8b8c
Various fixes
LysandreJik 5cb3708
Minor docs improvements
bc42e80
Merge branch 'tapas_v3' into tapas-truncation
NielsRogge 4200d40
Merge pull request #3 from huggingface/tapas-truncation
NielsRogge 57b6205
Add model integration test first draft
545ed40
Added URLs of models in model hub
cd8f5a1
Fix bug, currently 28 tests passed, 6 failed, 7 skipped
f38c4c1
Improve testing
e4fe878
Fix URLs in configuration_tapas.py
38c567f
Improve integration tests
2b71201
Add integration test for loss calculation
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.