Skip to content

Conversation

@sshleifer
Copy link
Contributor

@sshleifer sshleifer commented Oct 27, 2020

Previously, if you have a doc style error in a .rst file,

python utils/style_doc.py $(modified_py_files) --max_len 119;

wouldn't catch it

@sshleifer sshleifer requested a review from sgugger October 27, 2020 03:07
@sgugger
Copy link
Collaborator

sgugger commented Oct 27, 2020

Ideally there should be a modified_py_and_rst_files to speed up this check (and only apply it to modified files), but this works in the meantime. @stas00 if you want to do that last bit of optimization, let me know, otherwise I'll do that later.

@sshleifer sshleifer merged commit d93acd6 into huggingface:master Oct 27, 2020
@sshleifer sshleifer deleted the move-style-doc-check branch October 27, 2020 13:42
@stas00
Copy link
Contributor

stas00 commented Oct 27, 2020

Go for it, @sgugger. The modified files var is there, so it should be easy to apply it anywhere.

If you get stuck I'm here to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants