Skip to content

DEP: pinned sentencepiece to 0.1.91 in setup.py to fix build issues with newer versions #8069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LysandreJik merged 2 commits into from
Oct 27, 2020
Merged

DEP: pinned sentencepiece to 0.1.91 in setup.py to fix build issues with newer versions #8069

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1bcbe4
DEP: pinned sentencepiece to 0.1.91 in setup.py
Oct 26, 2020
be9f33c
Merge branch 'master' into pin_sentencepiece_version
LysandreJik Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,13 @@
extras["serving"] = ["pydantic", "uvicorn", "fastapi", "starlette"]
extras["all"] = extras["serving"] + ["tensorflow", "torch"]

extras["sentencepiece"] = ["sentencepiece!=0.1.92"]
extras["sentencepiece"] = ["sentencepiece==0.1.91"]
extras["retrieval"] = ["faiss-cpu", "datasets"]
extras["testing"] = ["pytest", "pytest-xdist", "timeout-decorator", "parameterized", "psutil"] + extras["retrieval"]
# sphinx-rtd-theme==0.5.0 introduced big changes in the style.
extras["docs"] = ["recommonmark", "sphinx", "sphinx-markdown-tables", "sphinx-rtd-theme==0.4.3", "sphinx-copybutton"]
extras["quality"] = ["black >= 20.8b1", "isort >= 5.5.4", "flake8 >= 3.8.3"]
extras["dev"] = extras["testing"] + extras["quality"] + extras["ja"] + ["scikit-learn", "tensorflow", "torch", "sentencepiece!=0.1.92"]
extras["dev"] = extras["testing"] + extras["quality"] + extras["ja"] + ["scikit-learn", "tensorflow", "torch", "sentencepiece==0.1.91"]

setup(
name="transformers",
Expand Down Expand Up @@ -130,7 +130,7 @@
# for OpenAI GPT
"regex != 2019.12.17",
# for SentencePiece models
"sentencepiece != 0.1.92",
"sentencepiece == 0.1.91",
"protobuf",
# for XLM
"sacremoses",
Expand Down